metaslab: expose zfs_metaslab_condense_pct and zfs_metaslab_sm_blksz_* on Linux#18594
Open
chrislongros wants to merge 1 commit into
Open
metaslab: expose zfs_metaslab_condense_pct and zfs_metaslab_sm_blksz_* on Linux#18594chrislongros wants to merge 1 commit into
chrislongros wants to merge 1 commit into
Conversation
behlendorf
approved these changes
May 27, 2026
Contributor
Author
What about |
Member
I'd think all 3 should go same way for uniformity. We don't have "spacemap" node, but we do have "metaslab" node, where the other two are living now. |
behlendorf
added
Status: Code Review Needed
chrislongros
force-pushed
the
feature/expose-zfs-condense-pct-on-linux
branch
from
5ecf8ec to
459cb7f
Compare
github-actions
Bot
removed
the
Status: Revision Needed
chrislongros
changed the title
amotin
reviewed
Jun 1, 2026
| "Block size for space map in pools with log space map disabled. " | ||
| "Power of 2 greater than 4096."); | ||
|
|
||
| ZFS_MODULE_PARAM(zfs_metaslab, zfs_metaslab_, sm_blksz_with_log, INT, ZMOD_RD, |
Member
There was a problem hiding this comment.
I don't see a point why those two are read-only. Lets make them ZMOD_RW.
chrislongros
force-pushed
the
feature/expose-zfs-condense-pct-on-linux
branch
from
459cb7f to
e831c45
Compare
chrislongros
force-pushed
the
feature/expose-zfs-condense-pct-on-linux
branch
from
e831c45 to
8fef94e
Compare
Expose zfs_metaslab_condense_pct and zfs_metaslab_sm_blksz_* as module parameters on Linux, matching their existing FreeBSD sysctls. Signed-off-by: Christos Longros <chris.longros@gmail.com>
chrislongros
force-pushed
the
feature/expose-zfs-condense-pct-on-linux
branch
from
8fef94e to
8f02983
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
zfs_condense_pctcontrols how aggressively per-metaslab on-disk space maps are rewritten in compact form.zfs_metaslab_sm_blksz_with_logcontrols Block size for space map in pools with log space map enabled.They are already tunables on FreeBSD but had no Linux equivalents.
Description
zfs_condense_pctandzfs_metaslab_sm_blksz_*withZFS_MODULE_PARAMinmodule/zfs/metaslab.c, alongside the existing metaslab tunables.man/man4/zfs.4.How Has This Been Tested?
Tested on an Arch Linux VM with the patched module.
Types of changes
Checklist:
Signed-off-by.